guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add package definition for GNU XaoS


From: Alex Kost
Subject: Re: [PATCH] Add package definition for GNU XaoS
Date: Tue, 15 Dec 2015 22:24:15 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Fabian Harfert (2015-12-15 00:01 +0300) wrote:

> Hello,
>
> this is my first contribution to this project.  I hope everything is
> right with this package definition for GNU XaoS
> (see https://www.gnu.org/software/xaos/).  It's a nice program to
> discover fractals, so I decided to use it for my first packaging
> attempt.

Hello, great attempt!  And thank you for showing this awesome program!
I didn't know about it.

[...]
> +(define-public xaos
> +  (package
> +    (name "xaos")
> +    (version "3.6")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +                "15cd1cx1dyygw6g2nhjqq3bsfdj8sj8m4va9n75i0f3ryww3x7wq"))))
> +    (build-system gnu-build-system)
> +    (native-inputs `(("gettext", gnu-gettext)))
It should be:         `(("gettext" ,gnu-gettext))
                                  ^^

> +    (inputs `(("libx11" ,libx11)
> +              ("zlib" ,zlib)
> +              ("libpng" ,libpng)
> +              ("gsl" ,gsl)))
> +    (arguments
> +     `(#:tests? #f ;no "check" target
> +       #:make-flags '("LOCALEDIR=$DATAROOTDIR/locale")))
> +    (synopsis "Real-time fractal zoomer")
> +    (description "GNU XaoS is a graphical program that generates fractal 
> patterns and

Please do not make such long lines, we stay within 80 columns (I
personally prefer to stay within 72 if possible).

> +allows you to zoom in and out of them infinitely in a fluid, continuous
> +manner.  It also includes tutorials that help to explain how fractals are
> +built.  It can generate many different fractal types such as the Mandelbrot
> +set.")
> +    (home-page "http://www.gnu.org/software/xaos/";)
> +    (license license:gpl2+)))

Otherwise, the patch looks good to me, so if there will be no other
comments I'll push it soon.

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]