guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Replace broken LADSPA URL.


From: Ricardo Wurmus
Subject: Re: [PATCH] Replace broken LADSPA URL.
Date: Mon, 28 Dec 2015 20:29:10 +0100
User-agent: mu4e 0.9.13; emacs 24.5.1

Alex Vong <address@hidden> writes:

> From 2feefc6fd7162d7226015aa296ace0c8e7d034bf Mon Sep 17 00:00:00 2001
> From: Alex Vong <address@hidden>
> Date: Thu, 12 Nov 2015 01:19:44 +0800
> Subject: [PATCH] gnu: ladspa: Update urls.
>
> * gnu/packages/audio.scm (ladspa): Update source and home page url.
>
> Thanks to Ricardo Wurmus for suggesting downloading the source
> from Internet Archive.

Thanks, but attribution is not required here :)

>  gnu/packages/audio.scm | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 6a8347a..9f3c217 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -817,15 +817,22 @@ plugin function as a JACK application.")
>    (package
>      (name "ladspa")
>      (version "1.13")
> -    (source (origin
> -             (method url-fetch)
> -             (uri (string-append
> -                   "http://www.ladspa.org/download/ladspa_sdk_";
> -                   version
> -                   ".tgz"))
> -             (sha256
> -              (base32
> -               "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Since the official link is dead,
> +       ;; we download the tarball from Debian or Internet Archive.
> +       (uri (list (string-append "http://http.debian.net";
> +                                 "/debian/pool/main/l/ladspa-sdk/ladspa-sdk_"
> +                                 version
> +                                 ".orig.tar.gz")

My preference is to keep “version” and the following string on the same
line because they are both short.

> +                  (string-append 
> "https://web.archive.org/web/20140717172251/";
> +                                 "http://www.ladspa.org/download/ladspa_sdk_";
> +                                 version
> +                                 ".tgz")))

Same here.  (It’s just a nitpick.)

> +       (sha256
> +        (base32
> +         "0srh5n2l63354bc0srcrv58rzjkn4gv8qjqzg8dnq3rs4m7kzvdm"))))
>      (build-system gnu-build-system)
>      (arguments
>       `(#:tests? #f  ; the "test" target is a listening test only
> @@ -843,7 +850,9 @@ plugin function as a JACK application.")
>                (("^CC.*")            "CC = gcc\n")
>                (("^CPP.*")           "CPP = g++\n"))))
>          (alist-delete 'build %standard-phases))))
> -    (home-page "http://ladspa.org";)
> +    ;; Since the home page is gone, we provide a link to the archived 
> version.
> +    (home-page
> +     "https://web.archive.org/web/20140729190945/http://www.ladspa.org/";)
>      (synopsis "Linux Audio Developer's Simple Plugin API (LADSPA)")
>      (description
>       "LADSPA is a standard that allows software audio processors and effects

Do you have permission to push or should I apply this on your behalf?

~~ Ricardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]