guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gtk+: Support GUIX_GTK{2,3}_PATH variables.


From: Mark H Weaver
Subject: Re: [PATCH] gtk+: Support GUIX_GTK{2,3}_PATH variables.
Date: Tue, 29 Dec 2015 22:23:57 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Mark H Weaver <address@hidden> writes:

> Ricardo Wurmus <address@hidden> writes:
>
>> Ludovic Courtès <address@hidden> writes:
>>
>>> Ricardo Wurmus <address@hidden> skribis:
>>>
>>>> Ludovic Courtès <address@hidden> writes:
>>>>
>>>>> Ricardo Wurmus <address@hidden> skribis:
>>>>>
>>>>>> From 11f502281064525a067c1453cd2b7b663bf6c3bb Mon Sep 17 00:00:00 2001
>>>>>> From: Ricardo Wurmus <address@hidden>
>>>>>> Date: Thu, 3 Dec 2015 08:32:06 +0100
>>>>>> Subject: [PATCH 2/3] gnu: gtk+: Add patch to support GUIX_GTK3_PATH.
>>>>>>
>>>>>> * gnu/packages/patches/gtk3-respect-GUIX_GTK3_PATH: New file.
>>>>>> * gnu-system.am (dist_patch_DATA): Add it.
>>>>>> * gnu/packages/gtk.scm (gtk+) [source]: Add patch.
>>>>>> [native-search-paths]: Add search path for GUIX_GTK3_PATH.
>>>>>
>>>>> LGTM.
>>>>>
>>>>> This will have to go to a separate branch.  We’ll get Hydra to build it
>>>>> once it’s done with the security updates.
>>>>
>>>> Could you push them to a new branch then?  I have no control over what
>>>> Hydra builds and I assume you’d want to rebase them on top of the
>>>> security updates.
>>>
>>> Here’s the deal: If you push a new branch based on current master, I’ll
>>> make sure Hydra builds it.  :-)
>>
>> I rebased the patches on top of current master and pushed them to a
>> new branch “gtk-path-patch”.
>
> I just rebased them again, and started Hydra building the branch.
>
> http://hydra.gnu.org/jobset/gnu/gtk-path-patch

This is now sufficiently built to merge to 'master', but I'm not sure
whether it was decided to do this before getting feedback from upstream.

>>>>> I agree with Andy that this needs to be discussed with upstream though.
>>>>> Could you open a bug on their tracker and explain the problem and
>>>>> proposed solution?
>>>>
>>>> Yes, I’ll take care of this.
>>
>> My email to address@hidden is still awaiting moderation :-/
>> Maybe I should try again after subscribing.

I haven't followed this thread, so I'll leave it to others to decide
how to proceed.

      Mark



reply via email to

[Prev in Thread] Current Thread [Next in Thread]