[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Gemspecs / Add ruby-ruby-engine.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Gemspecs / Add ruby-ruby-engine. |
Date: |
Tue, 05 Jan 2016 17:53:08 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> But how does this relate to snippets? In other build systems snippets
> cause the source archive to be unpacked, modified, and then repacked.
> If we split unpacking and gemspec extraction we’d have to make sure that
> this also works when snippets are involved, i.e. snippets should see the
> extracted gemspec (as the original one is discarded by the build system
> anyway).
The implementation of snippets is in ‘patch-and-repack’ procedure; it is
completely independent of build systems and their phases.
> Agreed. I’d be happy if someone else could chime in to give an opinion
> on whether to add a new phase or merge gemspec extraction with “unpack”.
I think I don’t understand the issue at hand sufficiently well. Two
things come to mind: “extract” and “unpack” sound synonymous; OTOH,
having a separate phase provides more flexibility, since one can remove
it, replace it, etc.
Ludo’.