Re: [PATCH 1/6] gnu: Add emacs-scheme-complete.

[Ludovic Courtès]

Federico Beffa <address@hidden> skribis:

> On Wed, Dec 30, 2015 at 6:32 PM, Federico Beffa <address@hidden> wrote:
>> Hi,
>>
>> I'm not sure about the license of this package. It just sates:
>>
>> ;;; This code is written by Alex Shinn and placed in the Public
>> ;;; Domain.  All warranties are disclaimed.

So this should be ‘public-domain’ from (guix licenses).

> From 61df8f50bd86fe14549095ab848ba887c5bb4185 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Thu, 24 Dec 2015 11:53:12 +0100
> Subject: [PATCH 1/6] gnu: Add emacs-scheme-complete.
>
> * gnu/packages/emacs.scm (emacs-scheme-complete): New variable.
> * gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch: New 
> patch.
> * gnu-system.am (dist_patch_DATA): Add the new patch.

[...]

> +(define-public emacs-scheme-complete
> +  (package
> +    (name "emacs-scheme-complete")
> +    (version "20151223.9b5cf224bf")
> +    (source
> +     (origin
> +       (file-name (string-append name "-" version))
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/ashinn/scheme-complete.git";)
> +             (commit "9b5cf224bf2a5994bc6d5b152ff487517f1a9bb5")))

Could you factorize the commit ID, as done by ‘libuv-julia’ for
instance?

> +    (synopsis
> +     "Smart tab completion for Scheme in Emacs")

Please move to previous line.

> +    (description
> +     "This file provides a single function, `scheme-smart-complete',

@code{scheme-smart-complete}

> +which you can use for intelligent, context-sensitive completion for any 
> Scheme
> +implementation in Emacs.  To use it just load this file and bind that 
> function
> +to a key in your preferred mode.")
> +    (license license:gpl3+))) ;; check license

license:public-domain

> diff --git 
> a/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch 
> b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch
> new file mode 100644
> index 0000000..3e5d071
> --- /dev/null
> +++ b/gnu/packages/patches/emacs-scheme-complete-scheme-r5rs-info.patch

Please add a sentence explaining what this does, and possibly a link to
the upstream patch, bug report, or discussion.

OK with these changes, thanks!

Ludo’.