[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add Bioconductor importer and updater.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] Add Bioconductor importer and updater. |
Date: |
Thu, 7 Jan 2016 19:29:14 +0100 |
User-agent: |
mu4e 0.9.13; emacs 24.5.1 |
Ludovic Courtès <address@hidden> writes:
> Ricardo Wurmus <address@hidden> skribis:
>
>> Ludovic Courtès <address@hidden> writes:
>
>>> I was wondering whether this should be a separate script or not. A
>>> precedent would be the ELPA importer, which takes a repository name as
>>> an argument. We could have done the same with the CRAN importer here.
>>
>> I would prefer not to have a separate script, because there’s so much
>> duplication. I’ll look at the ELPA importer for inspiration.
>>
>> Should the CRAN importer have its name changed, though?
>
> I think it’s fine to call it CRAN, even if it supports other
> repositories. The CRAN and ELPA importers support the CRAN/ELPA
> repository formats, not just the same-named repositories.
Okay, this makes sense. Well, I think it’s ready for merging then.
Unless there are further comments I should consider I’ll push this by
the end of this week.
Thank you!
~~ Ricardo