[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/04] gnu: Add assword
From: |
Eric Bavier |
Subject: |
Re: [PATCH 04/04] gnu: Add assword |
Date: |
Fri, 5 Feb 2016 23:08:06 -0600 |
On Fri, 05 Feb 2016 19:49:30 -0800
Christopher Allan Webber <address@hidden> wrote:
> * gnu/packages/password-utils (assword): New variable.
> ---
> gnu/packages/password-utils.scm | 48
> ++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
[...]
> +(define-public assword
> + (package
> + (name "assword")
> + (version "0.8")
> + (source (origin
> + (method url-fetch)
> + (uri (list
> + (string-append
> + "http://http.debian.net/debian/pool/main/a/assword/"
> + "assword_" version ".orig.tar.gz")))
> + (sha256
> + (base32
> + "0dl4wizbi0r21wxzykm8s445xbvqim5nabi799dmpkdnnh8i546i"))))
> + (arguments
> + `(#:python ,python-2
> + #:tests? #f
Could you add a comment saying why the tests are disabled, even if
just "no tests"?
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'manpage
> + (lambda* (#:key outputs #:allow-other-keys)
> + (zero? (system* "make" "assword.1"))
> + (install-file
> + "assword.1"
> + (string-append (assoc-ref outputs "out")
> "/share/man/man1")))))))
You might need to wrap the two steps of this procedure in an "and" so
that the value of the "(zero? (system* ...))" isn't lost.
> + (build-system python-build-system)
> + (inputs
> + `(("python-setuptools" ,python2-setuptools)
> + ("python2-xdo" ,python2-xdo)
> + ("python2-pygpgme" ,python2-pygpgme)
> + ("python2-pygtk" ,python2-pygtk)
> + ("help2man" ,help2man)))
If help2man is only needed for manpage generation it would be best in
native-inputs.
> + (propagated-inputs
> + `(("xclip" ,xclip)))
> + (home-page "https://finestructure.net/assword/")
> + (synopsis "Simple and secure password management system")
Perhaps just "Password manager"?
> + (description "assword is a simple password manager using GPG-wrapped
> +json files. It has a command line interface as well as a very simple
> +graphical interface, which can even \"type\" your passwords into
> +any x11 window.")
s/json/JSON/;s/x11/X11/
Otherwise LGTM!
Thanks,
`~Eric