Re: [PATCH] gnu: Add tcllib.

[Leo Famulari]

On Thu, Feb 11, 2016 at 10:11:07PM +0100, Jan Nieuwenhuizen wrote:
> Efraim Flashner writes:
> 
> Thanks for looking in so much detail!  New patch set attached.
> 
> >> +    (native-search-paths
> >> +     (list (search-path-specification
> > I don't think this needs to be a list
> 
> Yes, so it seems.
> 
> Still, I left (list) in for now as I feel uncomfortable changing 40
> other packages to remove that extra list, and I am even more hesitant to
> add a package that is the only exception not using (list) here.
> 
> 
> > . Also, it should be indented 2 spaces
> > (I believe)
> 
> I don't think so.  I use Emacs and verified other packages.
> 
> >> +      (files (list (string-append "lib/tcllib" version ""))))))
> > why the double quote after version?
> 
> Oops, removed.  That was an experiment trying to load the cmdline
> package.
> 
> >> + (description "Tcllib, the standard Tcl library, is a collection of
> >> common utility
> > utility should be on the next line
> 
> >> + functions and modules all written in high-level Tcl.
> >> +")
> > the ") should be on the previous line
> 
> Re-indented.
> 
> > I can't find it on the FSF list 
> > (https://www.gnu.org/licenses/license-list.html), 
> > but according to https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing,
> > the Tcl license is a FSF approved license, so another patch before this one
> > to add it to the license list would be good. It's possible that I'm wrong, 
> > so
> > if someone else can check me that'd be good.
> 
> I moved the description to a new tcl/tk license and have all (2)
> packages use that now.

Does anyone object to having a slash in the license variable name? I
don't know whether or not its "safe" [0].

I made some minor changes to your patch series.

I made the commit messages match the conventions of the project (mostly
the GNU changelog format AFAIK). I like to search the git log for
examples when I am commiting a type of patch for the first time.

I mentioned the Tcl/Tk project in the license description field.

And I tried to follow the unusual licensing naming convention of
tcl.scm, which I am not familiar with.

Can you check if it works for you? I don't really know how to test this
package.

[0] I'm traumatized by the Bourne shell ;)

0001-licenses-Add-tcl-tk-license.patch
Description: Text Data

0002-gnu-tcl-Use-tcl-tk-license.patch
Description: Text Data

0003-gnu-Add-tcllib.patch
Description: Text Data