guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 6/7] gnu: irssi: Use 'modify-phases'.


From: Ricardo Wurmus
Subject: Re: [PATCH 6/7] gnu: irssi: Use 'modify-phases'.
Date: Sun, 28 Feb 2016 16:48:54 +0100
User-agent: mu4e 0.9.13; emacs 24.5.1

Andreas Enge <address@hidden> writes:

> ...
>
> On Sun, Feb 28, 2016 at 12:10:11PM +0200, Efraim Flashner wrote:
>> * gnu/packages/irc.scm (irssi)[arguments]: Use 'modify-phases'.
>
> Nothing to say. I think it could be combined with the previous commit,
> but this is also not a problem.
>
> ...

I think it is good to keep syntax changes separate in general, but in
this case there doesn’t seem to be much value as the whole expression is
changed anyway (due to the move to a different module).

I still have a slight preference to keep the commit separate, though.

~~ Ricardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]