[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] gnu: Add gst-python.
From: |
宋文武 |
Subject: |
Re: [PATCH 4/4] gnu: Add gst-python. |
Date: |
Mon, 07 Mar 2016 09:59:08 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> 宋文武 <address@hidden> skribis:
>
>> * gnu/packages/gstreamer.scm (python-gst, python2-gst): New variables.
>
> [...]
>
>> + (arguments
>> + `(#:configure-flags
>> + (let ((python-sitedir
>> + ;; XXX: make this a package property?
>> + ,(string-append "lib/python"
>> + (version-major+minor (package-version python))
>> + "/site-packages")))
>
> I think the directory name should be computed on the “build side”,
> possibly using ‘get-python-version’ from (guix build
> python-build-system) or something equivalent.
>
> That way, ‘python2-gst’ wouldn’t have to duplicate this snippet.
Cool, I did that and pushed, with comment that ‘get-python-version’ is a
private function, hope someone will factorize it later.
Thanks for the reviews!