Re: [PATCH] gnu: simple-scan: Update to 3.19.91.

[Leo Famulari]

On Tue, Mar 08, 2016 at 11:04:35PM +0100, Tobias Geerinckx-Rice wrote:
> * gnu/packages/gnome.scm (simple-scan): Update to 3.19.91.

Thanks for your attention to this package!

Except where necessary for the new version to work, it's best to do
updates in a separate commit from other changes.

I can apply the update myself if you say it's okay to do on its own, or
feel free to submit a revised patch set.

> [arguments]: Disable PackageKit support irrelevant for Guix.

[...]

> +    (arguments
> +     '(#:configure-flags '("--disable-packagekit")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'clean
> +                    (lambda _
> +                      ;; Remove a left-over reference to PackageKit.
> +                      (delete-file "src/ui.c"))))))

Does 'src/ui.c' cause problems for us? I'd rather not make changes to
upstream code except when necesssary [0], at least not without
discussing it with upstream first.

[0] For example, when fixing portability issues or deleting non-free and
non-essential bundled components. The impact of the change should be
well-understood by reviewers, at the very least ;)