[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] gnu: openexr: Disable broken test to fix build on i686.
From: |
Leo Famulari |
Subject: |
Re: [PATCH 1/1] gnu: openexr: Disable broken test to fix build on i686. |
Date: |
Fri, 11 Mar 2016 15:09:06 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Fri, Mar 11, 2016 at 03:41:49PM +0100, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
>
> > * gnu/packages/graphics.scm (openexr)[arguments]: New field.
> > ---
> > gnu/packages/graphics.scm | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
> > index c022d74..3c5ad72 100644
> > --- a/gnu/packages/graphics.scm
> > +++ b/gnu/packages/graphics.scm
> > @@ -206,6 +206,20 @@ exception-handling library.")
> > "\"/tmp/\"")))
> > (patches (list (search-patch
> > "openexr-missing-samples.patch")))))
> > (build-system gnu-build-system)
> > + (arguments
> > + '(#:phases
> > + (modify-phases %standard-phases
> > + (add-after 'unpack 'disable-broken-test
> > + ;; This test fails on i686. Upstream developers suggest that
> > + ;; this test is broken on i686 and can be safely disabled:
> > + ;;
> > https://github.com/openexr/openexr/issues/67#issuecomment-21169748
> > + (lambda _
>
> Better to indent the comment with “(lambda” below.
Okay, pushed with that change!
>
> Otherwise LGTM, thanks for fixing this!
>
> Ludo’.