[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/6] gnu: Add borg.
From: |
Alex Kost |
Subject: |
Re: [PATCH 5/6] gnu: Add borg. |
Date: |
Tue, 22 Mar 2016 23:20:37 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Leo Famulari (2016-03-22 01:52 +0300) wrote:
> On Mon, Mar 21, 2016 at 06:35:19PM -0400, Leo Famulari wrote:
>> I asked upstream about some warnings during the docs generation, and
>> they pointed out that I needed to add a command line. I've attached a
>> revised patch.
>>
>> Can I get some feedback on it?
>
> Based on feedback on #guix, I've revised it again. Attached...
> From: Leo Famulari <address@hidden>
> Date: Mon, 14 Mar 2016 19:34:25 -0400
> Subject: [PATCH 5/6] gnu: Add borg.
>
> * gnu/packages/backup.scm (borg): New variable.
[...]
> +(define-public borg
> + (package
> + (name "borg")
> + (version "1.0.0")
> + (source (origin
> + (method url-fetch)
> + (uri (pypi-uri "borgbackup" version))
> + (sha256
> + (base32
> + "0wa6cvqs3rni5nwrgagigchcly8a53rxk56z0zn8iaii2cqrw2sh"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'set-env
> + (lambda* (#:key inputs #:allow-other-keys)
> + (let ((openssl (assoc-ref inputs "openssl"))
> + (lz4 (assoc-ref inputs "lz4")))
> + (setenv "BORG_OPENSSL_PREFIX" openssl)
> + (setenv "BORG_LZ4_PREFIX" lz4)
> + (setenv "PYTHON_EGG_CACHE" "/tmp")
> + #t)))
If you keep #t inside 'let', then align it to (setenv ...), or move it
away from 'let':
(lambda* (#:key inputs #:allow-other-keys)
(let ((openssl (assoc-ref inputs "openssl"))
(lz4 (assoc-ref inputs "lz4")))
(setenv "BORG_OPENSSL_PREFIX" openssl)
(setenv "BORG_LZ4_PREFIX" lz4)
(setenv "PYTHON_EGG_CACHE" "/tmp"))
#t)
Note the difference: another ')' after the last (setenv ...).
> + (add-after 'install 'docs
Perhaps it is better to call this phase 'install-doc'. It's a usual
name that can be met in other recipes. There is also
'install-man-pages' phase name, but I prefer 'install-doc'.
The rest looks good to me, so if you checked that this program works, I
think you can push this patchset.
--
Alex
- Re: [PATCH 4/6] gnu: python-llfuse: Update to 1.0, keep 0.41 variant., (continued)
- [PATCH 3/6] gnu: attic: Specify dependency on address@hidden, Leo Famulari, 2016/03/14
- [PATCH 5/6] gnu: Add borg., Leo Famulari, 2016/03/14
- Re: [PATCH 5/6] gnu: Add borg., Alex Kost, 2016/03/15
- Re: [PATCH 5/6] gnu: Add borg., Leo Famulari, 2016/03/15
- Re: [PATCH 5/6] gnu: Add borg., Leo Famulari, 2016/03/21
- Re: [PATCH 5/6] gnu: Add borg., Leo Famulari, 2016/03/21
- Re: [PATCH 5/6] gnu: Add borg., Leo Famulari, 2016/03/21
- Re: [PATCH 5/6] gnu: Add borg.,
Alex Kost <=
- Re: [PATCH 5/6] gnu: Add borg., Leo Famulari, 2016/03/22
- Re: [PATCH 5/6] gnu: Add borg., Alex Kost, 2016/03/23
- Re: [PATCH 5/6] gnu: Add borg., Efraim Flashner, 2016/03/23
[PATCH 6/6] gnu: address@hidden: Update to 0.41.1., Leo Famulari, 2016/03/14
[PATCH 2/6] gnu: python-msgpack: Use 'python2-variant'., Leo Famulari, 2016/03/14
[PATCH 1/6] gnu: python-msgpack: Update to 0.4.7., Leo Famulari, 2016/03/14
Re: [PATCH 0/6] Add borg, Leo Famulari, 2016/03/24