[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add gnu-maintain and gnu-standards.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add gnu-maintain and gnu-standards. |
Date: |
Fri, 25 Mar 2016 11:18:20 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Jan Nieuwenhuizen <address@hidden> skribis:
> From 914756aa6c8893ce68f57dab575ed67f4d5ae560 Mon Sep 17 00:00:00 2001
> From: Jan Nieuwenhuizen <address@hidden>
> Date: Wed, 23 Mar 2016 22:18:46 +0100
> Subject: [PATCH] gnu: Add gnu-maintain and gnu-standards.
>
> * gnu/packages/gnu-doc.scm: New file.
Please add it to gnu-system.am as well.
The ‘miscfiles’ package should probably go to the same module (in a
separate commit.)
> + (source (origin
> + (method url-fetch)
> + (uri "http://www.gnu.org/prep/maintain/maintain.texi.tar.gz")
This is an unversioned URL where the file occasionally gets updated in
place, so it’s unsuitable.
I think this one should instead be taken from
:pserver:address@hidden:/sources/gnustandards using
(guix cvs-download).
> +(define-public gnu-standards
> + (package
> + (name "gnu-standards")
> + (version "2015-04-23")
> + (source (origin
> + (method url-fetch)
> + (uri "http://www.gnu.org/prep/standards/standards.texi.tar.gz")
> + (sha256
> + (base32
> + "1rdyqk6d5bgrpmlnb8r65qif1h604jz1g7v3szh24cqga3mgi9py"))))
Likewise.
> + (description "The GNU Coding Standards were written by Richard Stallman
> and other GNU Project volunteers. Their purpose is to make the GNU system
> clean, consistent, and easy to install.")
Please shrink the line, as suggested by ‘guix lint’.
Could you send an updated patch?
Thanks,
Ludo’.