Re: [PATCH] gnu: Add Red Eclipse.

[Alex Kost]

Andreas Enge (2016-05-03 22:23 +0300) wrote:

> On Tue, May 03, 2016 at 10:08:52PM +0300, Alex Kost wrote:
>> Only the package name is renamed here.  I think it would be more
>> consistent to rename the variable as well.
>
> My apologies, indeed. I will push an additional patch.

I see, thanks!

> On Tue, May 03, 2016 at 10:09:40PM +0300, Alex Kost wrote:
>> Probably; you are the master of guidelines, so I trust your judge :-)
>> OTOH we also have such packages as 'accountsservice', 'recordmydesktop',
>> 'randomjungle', 'rubberband' and others.  Should they also be renamed to
>> 'accounts-service', 'record-my-desktop', 'random-jungle', 'rubber-band',
>
> It depends; I just noticed for red-eclipse since you brought up the question.
> Now I just checked accountsservice:
>               (uri (string-append "https://www.freedesktop.org/software/";
>                                   name "/" name "-" version ".tar.xz"))
>     (description
>      "The AccountService project provides a set of D-Bus interfaces for 
> querying
> It looks as if this should remain accountservice, since there is no space
> in the project name.
> The same holds for recordmydesktop.

OK, got it.

> For randomjungle, the tarball does not contain a space, the description does;
> then it is up to us to make a decision on what the project name is. The
> tarball name is always fine.
> The same holds for rubber band.
>
> It might also be more awkward to modify names of packages that are already
> there for some time.

I agree, thanks for clarifying.

-- 
Alex