guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] gnu: Add utfcpp.


From: Alex Griffin
Subject: Re: [PATCH 1/3] gnu: Add utfcpp.
Date: Sun, 08 May 2016 09:43:28 -0500

On Sun, May 8, 2016, at 03:13 AM, Alex Kost wrote:
> I suggest (gnu packages textutils); I see 'utf8proc' is placed there.  I
> think this is also a suitable module for 'libunistring' (currently it is
> placed in its own file), but it's a separate question.

Okay. I had assumed textutils was for command line utilities, but if
that's where utf8proc goes then utfcpp seems to fit there too.

> Not a big thing but we indent '#:use-module' by 2 spaces.  Out of
> curiosity: what editor do you use?

I use Emacs, the bad indenting is just from moving the package out of
another file with incorrect indentation (finance.scm).

> I don't know whether we have an idiomatic way to convert "2.3.4" into
> "2_3_4", but I would just use a tarball from github:

The project was just migrated to GitHub and hasn't had a new release
since then, so I'm using the sourceforge zip file because that's what
other projects have downloaded and used. Also I try to avoid the
automatically-generated GitHub archives because they're prone to change
hashes (although I see I forgot about that in the ledger package.)

> Please don't add leading spaces in descriptions :-)

Okay. My updated patches should come later today. Thanks!
-- 
Alex Griffin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]