[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FIXUP: [PATCH 01/10] gnu: cross: Use CROSS_*_INCLUDE_PATH for system
From: |
Jan Nieuwenhuizen |
Subject: |
Re: FIXUP: [PATCH 01/10] gnu: cross: Use CROSS_*_INCLUDE_PATH for system headers. |
Date: |
Sat, 14 May 2016 22:50:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ludovic Courtès writes:
> Thanks for your quick response, applied with an adjusted commit log.
Thanks.
> I concur with Mark: this is a very sensitive area that takes time to
> test and adjust, which is the main reason why it takes me so much time
> to review and such ;-), so we want to make sure we don’t break it.
Sure, I agree. These two real silly problems I introduced only makes me
appreciate more that it takes some time to get the patches in ;-)
> In the future, please make sure to test individual patches with the
> known-good *-linux-gnu targets.
Yes. I wrongly assumed (though that I knew and saw happen) that
cross-gcc and cross-libc were used in the bootstrap process that I was
thus testing them...I've seen a lot of my build host compilers and libc
getting built and rebuilt. Now I know that's not the case and need to
test for that when touching this area. That's still no excuse for
not testing the cross-base.scm patches individually :-/
I would still like to explore getting rid of the patched gcc and all
the environment variables and use a --sysroot instead; but I would
need some help/inspiration to get that experiment going.
Greetings, Jan
--
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.nl