Re: [PATCH] Emacs Zenburn

[Catonano]

2016-05-17 20:10 GMT+02:00 Alex Kost <address@hidden>:

Catonano (2016-05-17 13:12 +0300) wrote:

> I made a new patch trying to adhere to your indications
>
> Only, I'm having troubles with git-send-email so now I'm trying to attach
> the new patch to this email in a different way, maybe this time you can
> access it ?

Yes, perfect, thanks!

> From 359d604b8cfb42726efc932a9002e7d69f439f83 Mon Sep 17 00:00:00 2001
> From: humanitiesNerd <address@hidden>
> Date: Tue, 17 May 2016 10:54:13 +0200
> Subject: [PATCH] gnu: Add emacs-zenburn-theme

As I wrote in the previous message, the commit message should be:

  gnu: Add emacs-zenburn-theme.

  * gnu/packages/emacs.scm (emacs-zenburn-theme): New variable.

Please keep it in mind next time ;-)

I was sure I had reached the right format.

I took a look at the patch as you published. Note taken.
 

"guix lint emacs-zenburn-theme" reports that «the source file name
should contain the package name».  This happens because (by default)
this tarball has the following name in the store:

  /gnu/store/…-v2.4.tar.gz

It is better to have something more understandable, like:

  /gnu/store/…-emacs-zenburn-theme-2.4.tar.gz

This can be achieved by adding the following line to the 'origin':

  (file-name (string-append name "-" version ".tar.gz"))

Sorry, it slipped. Thank you for fixing that
 

I made the mentioned changes, added a copyright line for you and
committed it as 9576cc7¹.  Thanks for contributing!

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=9576cc72dc4f2973551c72951e64e5bf6240ff6b

It was a pleasure !

Thank you Alex ;-)