guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/6] build-system/emacs: Use "emacs" from native-inputs if sp


From: Ludovic Courtès
Subject: Re: [PATCH 2/6] build-system/emacs: Use "emacs" from native-inputs if specified.
Date: Sun, 22 May 2016 22:30:39 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Alex Kost <address@hidden> skribis:

> Ludovic Courtès (2016-05-20 15:00 +0300) wrote:
>
>> Federico Beffa <address@hidden> skribis:
>>
>>> Alex Kost <address@hidden> writes:
>>>
>>>> * guix/build-system/emacs.scm (lower): Do not add "emacs" to
>>>>   build-inputs if it is already specified in the native-inputs.
>>>> @@ -73,8 +75,16 @@
>>>>
>>>>                          ;; Keep the standard inputs of 'gnu-build-system'.
>>>>                          ,@(standard-packages)))
>>>> -         (build-inputs `(("emacs" ,emacs)
>>>> -                         ,@native-inputs))
>>>> +         ;; Add emacs to build-inputs only if native-inputs do not contain
>>>> +         ;; emacs already.  This allows us to use non-default emacs for
>>>> +         ;; building.
>>>> +         (build-inputs (if (find (match-lambda
>>>> +                                   (("emacs" _ ...) #t)
>>>> +                                   (_ #f))
>>>> +                                 native-inputs)
>>>> +                           native-inputs
>>>> +                           `(("emacs" ,emacs)
>>>> +                             ,@native-inputs)))
>>>
>>> Note that for the interpreter we normally use a keyword, here #:emacs
>>> (in a similar way as, say, for the python-build-system there is
>>> #:python).  Your code overwrites its effect in a non-transparent way.
>>
>> Seconded, I prefer #:emacs, which is consistent with cmake-build-system,
>> python-build-system, etc.
>
> OK, I understand.  So we have to stick to a full-featured "emacs" for
> emacs-build-system, right?  Or do you have ideas how we could use
> "emacs-minimal" as the default emacs for building, and replace it with
> the full "emacs" for particular packages?

I think emacs-build-system should have a #:emacs parameter (just like
python-build-system has #:python), which would default to
‘emacs-minimal’.

Does that make sense?

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]