guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configu


From: Ben Woodcroft
Subject: Re: [PATCH 1/2] guix: ruby-build-system: Extract gemspec during 'configure'.
Date: Wed, 25 May 2016 22:42:19 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0

On 24/05/16 22:14, Ricardo Wurmus wrote:
Hi Ben,

I’m in favour of this change.  I agree with Dave that the name of this
phase should not be “configure”.

* guix/build/ruby-build-system.scm [build]: Move extraction from here ...
[configure]: ... to here.  New variable.
[first-gemspec]: New variable.
[standard-phases]: Add 'configure'.
I think these should be round parentheses.  Also “standard-phases”
should really be “%standard-phases”.

Thanks, all pushed.
ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]