[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] build: emacs: Handle sources that are a single elisp fil
From: |
Alex Kost |
Subject: |
Re: [PATCH 1/2] build: emacs: Handle sources that are a single elisp file. |
Date: |
Sat, 28 May 2016 22:05:24 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ludovic Courtès (2016-05-28 18:36 +0300) wrote:
> David Thompson <address@hidden> skribis:
>
>> * guix/build/emacs-build-system.scm (gnu:unpack)
>> (store-file->elisp-source-file, unpack): New procedures.
>> (%standard-phases): Use the new unpack procedure.
>
> Good idea, LGTM!
>
> Could you adjust users of ‘uncompressed-file-fetch’ in a subsequent
> commit, and remove ‘uncompressed-file-fetch’?
I object! I mean this should be discussed at least. I would really
prefer to keep (and document) 'uncompressed-file-fetch' and not to
update emacs-build-system for this case. It is possible, that once
we'll need to handle non-compressed files for another build system. So
it should also be adjusted in the same way. But if we keep
'uncompressed-file-fetch', it will be a general decision as it can be
used for any build system.
--
Alex
Solving the ‘package-name->name+version’ name conflict. (was: [PATCH 1/2] build: emacs: Handle sources that are a single elisp file.), Mathieu Lirzin, 2016/05/30