Re: [PATCH] gnu: Add chromium-bsu.

[Kei Kebreau]

Leo Famulari <address@hidden> writes:

> On Tue, Jun 21, 2016 at 09:59:31AM -0400, Kei Kebreau wrote:
>> * gnu/packages/games (chromium-bsu): New variable.
>
>> +    (arguments
>> +     `(#:phases (modify-phases %standard-phases
>> +                  (add-after 'set-paths 'set-sdl-paths
>> +                             (lambda* (#:key inputs #:allow-other-keys)
>> +                               (setenv "CPATH"
>> +                                       (string-append (assoc-ref inputs 
>> "sdl-union")
>> +                                                      "/include/SDL"))
>> +                               #t)))))
>
> If you move (modify-phases) underneath #:phases, then this will be
> comfortably shorter than 80 characters :)
>
>> +    (native-inputs `(("pkg-config" ,pkg-config)))
>> +    (inputs `(("freeglut" ,freeglut)
>> +              ("glu" ,glu)
>> +              ("quesoglc" ,quesoglc)
>> +              ("sdl-union" ,(sdl-union (list sdl sdl-image sdl-mixer)))))
>
> The output doesn't refer to freeglut. I wonder if it should be
> native, propagated, or if it's not needed, etc?
>
> I ran the game on GuixSD, and it did work, although it was much slower
> than on my Debian system. I don't know if that was merely a consequence
> of the GuixSD system using much older hardware, or if it's related to
> the missing reference to freeglut.

The freeglut library is not needed. I mistakenly left out pkg-config in
an earlier build and added it because Chromium B.S.U. complained of a
missing glut library. A corrected patch is attached. (Also, I noticed no
speed difference between the two builds.)

0001-gnu-Add-chromium-bsu.patch
Description: Fixed patch.

-- 
Kei (GPG Key: 4096R/E6A5EE3C19467A0D)

signature.asc
Description: PGP signature