Re: [PATCH] Add khmer.

[Ben Woodcroft]

On 27 June 2016 3:34:42 AM AEST, Leo Famulari <address@hidden> wrote:
>On Sun, Jun 26, 2016 at 09:59:51PM +1000, Ben Woodcroft wrote:
>> I'm not convinced, I'm afraid. According to the SMHasher README [0]:
>> 
>> >This is the home for the MurmurHash
>> <https://github.com/aappleby/smhasher/tree/master/src> family of hash
>> functions along with the SMHasher
>> <https://github.com/aappleby/smhasher/tree/master/src> test suite
>used to
>> verify them.
>> 
>> So that would count that as an independent upstream distribution of
>> murmurhash, right?
>
>My understanding is that SMHasher does not create a library, but just
>provides raw source code, leaving it up to 3rd party software authors
>to
>integrate it into their applications. Is that right?

Yes. I don't see how that matters though, it is still bundling which should be 
avoided if possible right? What am I missing?

Ta, ben