guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add khmer.


From: Ben Woodcroft
Subject: Re: [PATCH] Add khmer.
Date: Mon, 27 Jun 2016 15:47:44 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0



On 27/06/16 15:01, Leo Famulari wrote:
On Mon, Jun 27, 2016 at 08:48:14AM +1000, Ben Woodcroft wrote:
On 27 June 2016 3:34:42 AM AEST, Leo Famulari <address@hidden> wrote:
On Sun, Jun 26, 2016 at 09:59:51PM +1000, Ben Woodcroft wrote:
I'm not convinced, I'm afraid. According to the SMHasher README [0]:

This is the home for the MurmurHash
<https://github.com/aappleby/smhasher/tree/master/src> family of hash
functions along with the SMHasher
<https://github.com/aappleby/smhasher/tree/master/src> test suite
used to
verify them.

So that would count that as an independent upstream distribution of
murmurhash, right?
My understanding is that SMHasher does not create a library, but just
provides raw source code, leaving it up to 3rd party software authors
to
integrate it into their applications. Is that right?
Yes. I don't see how that matters though, it is still bundling which should be 
avoided if possible right? What am I missing?
So far my understanding has been that, in Guix, we don't want to create
Guix-specific distributions of upstream code. SMHasher is the canonical
source for Murmur, but SMHasher doesn't seem suitable for building a
library that other applications can use, right?

It is true that copying code into 'include' is probably changing the developer's intended distribution model.

Do any other distros have a package for Murmur or SMHasher that we can
use as an example?

I could not find any.

Does anyone else have any thoughts about this?

Let's not worry about this further, I do not have such strong opinions and I've been outvoted. So I'll push with Ludo's and your suggested changes soon.

Thanks for the review and discussion.
ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]