Re: [PATCH] gnu: Add di.

[Leo Famulari]

On Mon, Jul 04, 2016 at 09:43:55AM +0300, Alex Kost wrote:
> John J Foerch (2016-07-04 06:47 +0300) wrote:
> > A test relating to an included perl module Filesys::di fails.  I hadn't
> > intended to include that module in the package, as all I'm interested in
> > is the 'di' binary.  Given that, I would suggest that we bypass the
> > tests.
> 
> As for me, I would also disable the tests.  All these handmade Makefiles
> in all sub-directories are a nightmare.  I think trying to figure out
> what is needed to run the tests doesn't worth it.

I agree that hand-carved Makefiles are difficult to work with.

The failing Perl-related test runs successfully if Perl is added to the
environment. However, there is another failure later on:

make[1]: Leaving directory '/tmp/guix-build-di-4.42.drv-0/di-4.42/C'
make -e tests.done
make[1]: Entering directory '/tmp/guix-build-di-4.42.drv-0/di-4.42'
## running tests
CC=gcc DC="skip"  \
        ./mkconfig/runtests.sh ./tests.d
mkconfig version 1.27
## locating valid shells
   /gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/bash [bash4 
4.3.42(1)-release] (ok)
   /gnu/store/b1yqjimbdh5bf9jnizd4h7yf110744j2-bash-4.3.42/bin/sh [sh-bash4 
4.3.42(1)-release] (ok)
buildsh ... build w/mkconfig.sh ... bash4 C* sh-bash4 C* ... failed
## stopping tests due to failures in ./tests.d/ pass 1
1 tests 1 failures
Makefile:116: recipe for target 'tests.done' failed
make[1]: *** [tests.done] Error 1
make[1]: Leaving directory '/tmp/guix-build-di-4.42.drv-0/di-4.42'
Makefile:112: recipe for target 'test' failed
make: *** [test] Error 2
phase `check' failed after 64.5 seconds

I skimmed 'mkconfig/runtests.sh', but I don't understand it well enough
to debug it.

If the source code is still maintained, I bet the authors will be
willing to help. They express interest in testing and portability on the
web page.

But if everyone else prefers to skip the tests, I won't object :)