Re: [PATCH 5/7] gnu: Add spice.

[Leo Famulari]

On Sat, Jul 23, 2016 at 03:18:57PM +0200, David Craven wrote:
> * gnu/packages/spice.scm: Add it.

> +(define-public spice

> +    (propagated-inputs
> +      `(("openssl" ,openssl)
> +        ("pixman" ,pixman)
> +        ("spice-protocol" ,spice-protocol)))

Same questions as with the previous patch. Do these need to be
propagated?

> +    (inputs
> +      `(("glib" ,glib)
> +        ("libjpeg" ,libjpeg)
> +        ("lz4" ,lz4)
> +        ("opus" ,opus)
> +        ("python" ,python)
> +        ("spice-gtk" ,spice-gtk)
> +        ("zlib" ,zlib)))

The built package is missing references to python and spice-gtk. Do you
think that's a problem? Are they needed?

> +      `(#:configure-flags
> +        '("--disable-celt051" 

Would a comment like "Disable support for unpackaged audio codec"
explain this flag?

> +    (license license:gpl2)))

Released under lgpl2.1+ with a few lgpl2.0+ files.