guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/11] gnu: ncurses: support mingw.


From: Jan Nieuwenhuizen
Subject: Re: [PATCH 07/11] gnu: ncurses: support mingw.
Date: Tue, 09 Aug 2016 17:59:26 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Alex Kost writes:

>> +                  (mingw-target? (lambda* (#:optional (target target))
>> +                                   (and target
>> +                                        (string-suffix? "-mingw32" 
>> target))))
>
> IIUC you don't use the same 'mingw-target?' procedure you added in an
> earlier patch, because it is placed in (guix utils), right?

Yes, something like that: the function needs to be present at in the
builder, but I'm not sure how we can make that so.  I tried several
things but could not find a way to avoid this duplication.
mingw-target? is passed the TARGET from the post-install-phase.

> I don't know if (guix build utils) would be a better place for it ,

How would that work?  mingw-target? uses %current-build-system which is
defined in (guix utils).  I agree that it would be nice to remove this
duplication.

> but I think this 'mingw-target?' may be used by other packages quite
> often, so it should be available by default to avoid the same
> definitions in other packages.

The definition from (guix utils) is used in libiconv-if-needed, in
cross-gcc, in guile and in readline.

Greetings,
Jan

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | AvatarĀ®  http://AvatarAcademy.nl  



reply via email to

[Prev in Thread] Current Thread [Next in Thread]