Re: [PATCH]: gnu: gnurl: Update to 7.50.1.

[ng0]

ng0 <address@hidden> writes:

> ng0 <address@hidden> writes:
>
>> Leo Famulari <address@hidden> writes:
>>
>>> On Fri, Aug 05, 2016 at 02:57:10PM +0000, ng0 wrote:
>>>> From 81f605a551a3cfcfe48fae27fd7aa5d9affa4bd2 Mon Sep 17 00:00:00 2001
>>>> From: ng0 <address@hidden>
>>>> Date: Fri, 5 Aug 2016 14:44:38 +0000
>>>> Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
>>>> 
>>>> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
>>>> [configure-flags]: Configure with --disable-smb.
>>>> Disable test1139.
>>>
>>> Can you add a comment explaining why test1139 is disabled? Just saying
>>> that it won't work doesn't tell those reading the package why it is
>>> disabled.
>>
>> My assumption: files or lines of code are searched which will not exist
>> in gnurl. If this is not just us (sadly in Gentoo i have test/checks
>> disabled for this package), I will fix this upstream.
>> If your perl knowledge is better look at the failing test yourself. This
>> is my best judgment with the little perl knowledge I have.
>> It was just ruling out what could cause the test failure.
>
> Is this okay?

Can someone tell me if this is okay or if it needs further changes?
I'd like to update this.

> From 8b99ce31e269334aa339af27c3e78577f73052ce Mon Sep 17 00:00:00 2001
> From: ng0 <address@hidden>
> Date: Fri, 5 Aug 2016 14:44:38 +0000
> Subject: [PATCH] gnu: gnurl: Update to 7.50.1.
>
> * gnu/packages/gnunet.scm (gnurl): Update to 7.50.1.
> [configure-flags]: Configure with --disable-smb.
> Disable test1139.
> ---
>  gnu/packages/gnunet.scm | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
> index 4d888bd..36aa8c0 100644
> --- a/gnu/packages/gnunet.scm
> +++ b/gnu/packages/gnunet.scm
> @@ -153,7 +153,7 @@ and support for SSL3 and TLS.")
>  (define-public gnurl
>    (package
>     (name "gnurl")
> -   (version "7.48.0")
> +   (version "7.50.1")
>     (source (origin
>              (method url-fetch)
>              (uri (let ((version-with-underscores
> @@ -162,7 +162,7 @@ and support for SSL3 and TLS.")
>                                    name "-" version-with-underscores 
> ".tar.bz2")))
>              (sha256
>               (base32
> -              "14gch4rdibrc8qs4mijsczxvl45dsclf234g17dk6c8nc2s4bm0a"))))
> +              "0irb8df3lqd9w1pb627q260hn448vbkh0sn4l6p6jh0q8lqscv84"))))
>     (build-system gnu-build-system)
>     (inputs `(("gnutls" ,gnutls)
>               ("libidn" ,libidn)
> @@ -183,17 +183,24 @@ and support for SSL3 and TLS.")
>                            "--disable-ldap" "--disable-rtsp" "--disable-dict"
>                            "--disable-telnet" "--disable-tftp" 
> "--disable-pop3"
>                            "--disable-imap" "--disable-smtp" 
> "--disable-gopher"
> -                          "--disable-file" "--disable-ftp")
> +                          "--disable-file" "--disable-ftp" "--disable-smb")
>       #:test-target "test"
>       #:parallel-tests? #f
> -     ;; We have to patch runtests.pl in tests/ directory
>       #:phases
> +     ;; We have to patch runtests.pl in tests/ directory
>        (alist-cons-before
>         'check 'patch-runtests
>         (lambda _
>           (substitute* "tests/runtests.pl"
> -                      (("/bin/sh") (which "sh"))))
> -       %standard-phases)))
> +           (("/bin/sh") (which "sh"))))
> +       ;; This test is disabled because of some reduction in code gnurl
> +       ;; implies, it can not succeed when some functions it expects are
> +       ;; not built.
> +       (alist-cons-before
> +        'check 'delete-failing-test1139
> +        (lambda _
> +          (delete-file "tests/data/test1139"))
> +       %standard-phases))))
>     (synopsis "Microfork of cURL with support for the HTTP/HTTPS/GnuTLS 
> subset of cURL")
>     (description
>      "Gnurl is a microfork of cURL, a command line tool for transferring data
> -- 
> 2.9.2
>
>
>
> -- 
> ♥Ⓐ  ng0
> Current Keys: https://we.make.ritual.n0.is/ng0.txt
> For non-prism friendly talk find me on http://www.psyced.org

-- 
♥Ⓐ  ng0
For non-prism friendly talk find me on http://www.psyced.org