[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add sg3_utils.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add sg3_utils. |
Date: |
Sun, 14 Aug 2016 12:46:32 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Sat, Aug 13, 2016 at 08:23:38PM -0700, Chris Marusich wrote:
> sg3_utils and its library can be used with any SCSI device, which
> includes many devices which are not hard disks, such as CD-ROMs and
> media changers (i.e., jukeboxes), so I don't think it makes sense to put
> it into a file whose scope is limited to disks.
Ah, I can't wait for jukebox.scm ;)
> >> + #:use-module ((guix licenses)
> >> + #:select (gpl2+ bsd-3))
> >
> > Do we need to use #:select here? How about using a license prefix? What
> > are the pros and cons?
I'll leave this as is.
> > We like to use underscores instead of hyphens in package names:
> >
> > https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html#Package-Naming
>
> Thank you for pointing this out. I've updated it (see attached patch).
Thanks for understanding my mistake; I got it backwards in the sentence
you replied to :p
>
> > I think that dd, and all the sg_* commands, should be wrapped in texinfo
> > markup, like this:
> >
> > @code{dd}
>
> Done! Thanks for the tip.
Thanks! Pushed as 5cf30103f7.
signature.asc
Description: PGP signature
Re: [PATCH] gnu: Add sg3_utils., Leo Famulari, 2016/08/13