|
From: | Alex Kost |
Subject: | Re: [PATCH 14/24] gnu: gstreamer: Use license: prefix. |
Date: | Tue, 16 Aug 2016 23:15:07 +0300 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
David Craven (2016-08-16 21:39 +0300) wrote: > * gnu/packages/gstreamer.scm (define-module): Import guix licenses with > #:prefix > license:. > (orc): Likewise. > (gstreamer): Likewise. > (gst-plugins-base): Likewise. > (gst-plugins-good): Likewise. > (gst-plugins-bad): Likewise. > (gst-plugins-ugly): Likewise. > (gst-libav): Likewise. > (python-gst): Likewise. ^^ Please remove the leading spaces before "(...): Likewise." I like this patch. However in general (a question for Guix people): is there a reason to use #:select for licenses? Or would it be better to use #:prefix everywhere? If the latter (my preference), I think it would be good to make this "#:select"→"#:prefix" change in a single patch instead of making separate patches for different modules. -- Alex
[Prev in Thread] | Current Thread | [Next in Thread] |