Re: [PATCH] Add tintin.

[Leo Famulari]

On Mon, Aug 08, 2016 at 09:21:09PM +0000, ng0 wrote:
> Updated patch.
> 
> * gnu/packages/games.scm (tintin): New variable.

Thanks!

> +              (uri (string-append "https://sourceforge.net/projects/tintin";
> +                                  "/files/TinTin++ Source Code/" version
> +                                  "/tintin" "-" version ".tar.gz"))

This URL does not work for me. Maybe you already had the tarball in your
/gnu/store? Also, it should use our SourceForge mirrors.

> +       #:phases
> +       (modify-phases %standard-phases
> +         ;; The source is in tt/src.
> +         (add-before 'configure 'chdir-to-tt-src
> +           (lambda _
> +             (chdir "src"))))))

I would call this phase 'chdir'.

> +    (home-page "http://tintin.sourceforge.net/";)

HTTPS, if possible.

Otherwise, looks good so far!