[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] gnu: Add python-lirc, python2-lirc.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH v3] gnu: Add python-lirc, python2-lirc. |
|
Date: |
Fri, 19 Aug 2016 17:46:38 -0400 |
|
User-agent: |
Mutt/1.6.2-neo (2016-07-23) |
On Wed, Aug 17, 2016 at 09:48:47PM +0300, Alex Kost wrote:
> Leo Famulari (2016-08-17 00:41 +0300) wrote:
>
> > On Tue, Aug 16, 2016 at 11:28:09PM +0200, Danny Milosavljevic wrote:
> >> gnu: Add python-lirc, python2-lirc.
> >>
> >> * gnu/packages/lirc.scm (python-lirc, python2-lirc): New variables.
> >
> > Thanks, applied as 231313f76!
>
> Ahem, you both are fast: I was commenting on the first patch, and
> suddenly found that the third revision is already pushed :-)
> Anyway, some comments:
I pushed fixes for the indentation and the misleading file-name.
> > + (description "@code{lirc} is a Python module which provides LIRC
> > bindings.")
>
> I don't think the description should begin with "@code{lirc}" as it is
> not LIRC itself but a python library for LIRC.
Not knowing what to replace this with, I left it alone.