Re: [PATCH 0/7] Add Prosody

[Ricardo Wurmus]

Leo Famulari <address@hidden> writes:

> On Mon, Aug 22, 2016 at 09:39:11PM +0200, Ricardo Wurmus wrote:
>> Hi Guix,
>> 
>> this patch series adds a package for the XMPP server Prosody.
>> 
>> The first patch is needed to allow Lua to load dynamic libraries via dlopen.
>> 
>> I'm not sure about the naming.  Prosody needs Lua 5.1, so I didn't even
>> attempt to build the Lua packages for any later version.  The variable names
>> all have a "lua5.1-" prefix, but the packages themselves don't; should they?
>
> I'm not sure either; I think this is fine.

On second thought we should change the package names to have a “lua5.1-”
prefix, because we do something similar with Python packages.

> I found the commit messages a little confusing, especially the luasec
> commit. It adds "luasec", but there is no package name or variable
> called "luasec". I know that the upstream package name is "LuaSec". A
> very minor quibble...

True.  I’ll change this so that the Guix package names are used.  In
this case this would mean changing “luasec” to “lua5.1-sec” in the
commit message.

~~ Ricardo