Re: [PATCH] gnu: Add dlib.

[Marius Bakke]

Marius Bakke <address@hidden> writes:

>> Without OpenBLAS dlib will use an internal BLAS implementation. I'm
>> fairly certain that will at least fix the crash on x86_64, which was
>> a segfault in libopenblasp-r0.2.15.so when we had LAPACK in inputs, but
>> seems to consistently trigger on Hydra regardless.
>>
>> I got busy this weekend, but will try to reproduce the i686 errors this
>> week; and also check if the newer openblas in core-updates solves the
>> x86_64 segfault.
>>
>> Stay tuned...
>
> Short update: I can successfully reproduce the i686 test failures simply
> by `guix build --system=i686-linux` on x86_64. Removing OpenBLAS from
> inputs had no effect. Now to figure out what's going on..

There are a couple of things going on in this thread:

1. Segfault on x86_64. This seems to have been resolved simply by
updating OpenBLAS. At least, I'm no longer able to reproduce it even
with LAPACK in inputs. So, that should fix the Hydra x86_64 build.
Can the OpenBLAS update be cherry-picked to master?

2. i686 test failures. Updating OpenBLAS fixed 1/5 errors. The remaining
four are reproducible on 32-bit Ubuntu, so they do not seem Guix
related. Upstream has been notified.

3. ARM failures. I don't have ARM hardware to test on, but I'm guessing
it's similar to i686 (i.e. not directly Guix related).

Adding "#:parallel-build? #f" had no effect on tests, indeed the check
phase does not seem to use the previously built dlib; it builds it again
without parallel-build. I will try reproducing the non-reproducibility
on some higher end hardware, hopefully this week.

I've also found that FFTW is no longer used, apparently due to thread
safety issues. So I'd appreciate if the following patch can be added.
Apologies for not catching the missing reference earlier, I will be more
careful in the future (fftw was added in the last minute..).

>From 714f38b31996e014ed0cc56391e379e2241ee26e Mon Sep 17 00:00:00 2001
From: Marius Bakke <address@hidden>
Date: Tue, 23 Aug 2016 21:17:14 +0100
Subject: [PATCH] gnu: dlib: Remove unused fftw from inputs.

* gnu/packages/machine-learning.scm (dlib)[inputs]: Remove fftw.
  (define-module): Don't include algebra.scm.
---
 gnu/packages/machine-learning.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/machine-learning.scm 
b/gnu/packages/machine-learning.scm
index 4332045..7669702 100644
--- a/gnu/packages/machine-learning.scm
+++ b/gnu/packages/machine-learning.scm
@@ -28,7 +28,6 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system r)
   #:use-module (gnu packages)
-  #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages compression)
@@ -515,8 +514,7 @@ single hidden layer, and for multinomial log-linear 
models.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (inputs
-     `(("fftw" ,fftw)
-       ("giflib" ,giflib)
+     `(("giflib" ,giflib)
        ;("lapack" ,lapack) XXX lapack here causes test failures in some setups.
        ("libjpeg" ,libjpeg)
        ("libpng" ,libpng)
-- 
2.9.3