guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 1/2] gnu: Add arduino-libraries.


From: Danny Milosavljevic
Subject: Re: [PATCH v6 1/2] gnu: Add arduino-libraries.
Date: Wed, 31 Aug 2016 22:40:37 +0200

> As this is only used by “arduino-libraries” and probably no other
> package I’d move this into the definition of “arduino-libraries”.

I suppressed arduino-core in this patch series. It will be used by others.

> Could you expand the description a little?  Maybe one more sentence.

What should I write?

Would "There are libraries for Ethernet, GSM, LCD, SD drives, servos, stepper 
motors, TFT displays and WiFi. " be OK?

> > +    ;;   libraries/Ethernet/src/utility/w5100*: lgpl2.1  
> 
> Only 2.1?  Or is a later version okay?

Only 2.1.

> > diff --git 
> > a/gnu/packages/patches/arduino-libraries-hardware-remove-__cxa_guard_acquire.patch
> >  
> > b/gnu/packages/patches/arduino-libraries-hardware-remove-__cxa_guard_acquire.patch
> >   
> 
> Please add a comment at the very top of this patch to explain what its
> purpose is.

"Removes function-static variable. Our avr-gcc chokes on it otherwise." ?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]