[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add u-boot.
From: |
Danny Milosavljevic |
Subject: |
Re: [PATCH] gnu: Add u-boot. |
Date: |
Wed, 31 Aug 2016 22:55:34 +0200 |
Hi Ludo,
On Wed, 31 Aug 2016 22:40:57 +0200
address@hidden (Ludovic Courtès) wrote:
> > + (lambda* (#:key outputs make-flags #:allow-other-keys)
> > + (let ((configname (string-append ,board "_defconfig")))
>
> Should be ‘config-name’ per our conventions, but ‘config’ is probably
> enough.
>
> > + (if (file-exists? (string-append "configs/" configname))
> > + (zero? (apply system* "make" `(,@make-flags
> > ,configname)))
> > + (begin
> > + (display "Invalid boardname. Valid boardnames would
> > have been:")
>
> “board name” (two words).
> > + (copy-file file-path target-file-path)))
> > + uboot-files)))))))))
>
> s/-path//
For the record, a filename (or file path) is something completely different
from a file. It makes no sense to call a filename "file". Likewise, a boardname
is the name of a board. It's not the board. A configname is the name of a
config [file]. "config" would be the configuration itself.
To develop this habit has taken a long time for me and it has paid off well.
I'm not totally against naming filenames "file" - or "f" for that matter - but
I distinguish for good reason.
Also when adapting gnu/system.scm etc for U-Boot I spent lots of time finding
out what are confignames and what are configurations because it likewise does
not distinguish.
A rose by any other name would smell as sweet, you know :)