Re: [PATCH] gnu: Use a directory owned by ntpd user for drift file.

[Ludovic Courtès]

John Darrington <address@hidden> skribis:

> Fixes bug #24366

Rather:

  Fixes <http://bugs.gnu.org/24366>.

(See ‘git log’ for examples.)

>
>
>
> * gnu/services/networking.scm (ntp-shepherd-service): Create new
> directory at startup.

Please mention the new variables and changes.

> +(define (ntp-service-activation config)
> +  "Return the activation gexp for config"
                                     ^^^^^^^
Capitalize the variable name and add a period.

> +  #~(begin
> +      (use-modules (guix build utils))

Please wrap the gexp in:

  (with-imported-modules '((guix build utils))
    #~(…))

> +      (let ((directory "/var/run/ntpd"))
> +          (mkdir-p directory)
            ^^
Indentation.

OK with these changes.

Thanks for fixing this bug!

Ludo’.