guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add git-review.


From: Efraim Flashner
Subject: Re: [PATCH] gnu: Add git-review.
Date: Thu, 8 Sep 2016 13:16:25 +0300
User-agent: Mutt/1.7.0 (2016-08-17)

On Thu, Sep 08, 2016 at 09:06:30AM +0200, Clément Lassieur wrote:
> * gnu/packages/openstack.scm (git-review): New variable.
> ---
>  gnu/packages/openstack.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index 8474904..2a54a20 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -1,6 +1,7 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2015 Cyril Roelandt <address@hidden>
>  ;;; Copyright © 2015, 2016 Efraim Flashner <address@hidden>
> +;;; Copyright © 2016 Clément Lassieur <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -20,6 +21,7 @@
>  (define-module (gnu packages openstack)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages tls)
> +  #:use-module (gnu packages version-control)
>    #:use-module (guix build-system python)
>    #:use-module (guix download)
>    #:use-module ((guix licenses)
> @@ -781,3 +783,30 @@ permanence.")
>           ("python2-oslosphinx" ,python2-oslosphinx)
>           ,@(fold alist-delete (package-native-inputs swiftclient)
>              '("python-keystoneclient" "python-oslosphinx")))))))
> +
> +(define-public git-review
> +  (package
> +    (name "git-review")
> +    (version "1.25.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             
> "https://pypi.python.org/packages/source/g/git-review/git-review-";
> +             version ".tar.gz"))

This should be (uri (pypi-uri "git-review" version))

> +       (sha256
> +        (base32
> +         "07d1jn9ryff5j5ic6qj5pbk10m1ccmpllj0wyalrcms1q9yhlzh8"))))
> +    (build-system python-build-system)
> +    (arguments `(#:tests? #f)) ; tests require a running Gerrit server
> +    (native-inputs
> +     `(("python-pbr" ,python-pbr)))
> +    (inputs
> +     `(("python-requests" ,python-requests)
> +       ("git" ,git)))
> +    (home-page "http://docs.openstack.org/infra/git-review/";)
> +    (synopsis "Command-line tool for Gerrit")
> +    (description
> +     "Git-review is a command-line tool that helps submitting Git branches to
> +Gerrit for review, or fetching existing ones.")
> +    (license asl2.0)))
> -- 
> 2.10.0
> 
> 

Does this also build for python-2?

-- 
Efraim Flashner   <address@hidden>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]