[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] services: nginx: Actually check if configuration is valid.
|
From: |
Thompson, David |
|
Subject: |
Re: [PATCH] services: nginx: Actually check if configuration is valid. |
|
Date: |
Thu, 8 Sep 2016 22:29:05 -0400 |
On Thu, Sep 8, 2016 at 10:21 PM, Tobias Geerinckx-Rice <address@hidden> wrote:
> Dave,
>
> On 09/09/16 04:09, Thompson, David wrote:
>> Maybe this could be done at build-time instead?
>
> The nginx service points to a stateful configuration file, like
> /etc/nginx.conf, that isn't built or handled by Guix.
No, it doesn't. I wrote the nginx service. The config file used is
part of the g-expression and is absolutely not stateful.
> I'd like that to change, but that will have to wait for now.
>
>> Would be nice to know that when you boot the system the nginx config
>> will be valid.
>
> It's currently printed near the end of ‘guix system reconfigure’, if
> that's what you mean.
I mean that it should throw an error before the system is made active.
The derivation that builds the service file should fail. Not
suggesting it needs to be done right now, but I think it would be
cool.
- Dave