[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Linux kernel
From: |
David Craven |
Subject: |
Re: Linux kernel |
Date: |
Sat, 10 Sep 2016 00:48:04 +0200 |
> Seems we already discussed some of these, no?
Ah yes, I missed this, sorry - No need to comment on this patch again:
>> Important note: (%current-target-system) returns a GNU triplet such as
>> “arm-linux-gnueabihf”, whereas (%current-system) returns a “system type”
>> such as “armhf-linux”.
>> In practice it works here, and ‘linux-libre-headers’ already does that,
>> so this patch is OK (can go to master).
>> However, we should augment the docstring of ‘system->linux-architecture’
>> to clarify that it accepts both a triplet and a system string. Could
>> you do that?
> Anyway, I’m fine with you sending the remaining patches with ‘git
> send-email’; it makes it easier to comment on the code for me.
Done.
> Nitpick: Use ‘base32’ here, rather than in the callee (that way, base32
> parsing happens at compile time and errors are detected early.)
Good to know, I wondered why we always need sha256 and base32 :-)
- [PATCH 17/17] gnu: Add linux-libre-beagle-bone-black., (continued)
- [PATCH 15/17] gnu: make-linux-libre: Add supported-systems parameter., David Craven, 2016/09/09
- Re: [PATCH 15/17] gnu: make-linux-libre: Add supported-systems parameter., Ludovic Courtès, 2016/09/11
- [PATCH 16/17] gnu: Add linux-libre-multi-v7., David Craven, 2016/09/09
- Re: [PATCH 16/17] gnu: Add linux-libre-multi-v7., Vincent Legoll, 2016/09/09
- Re: [PATCH 16/17] gnu: Add linux-libre-multi-v7., Ludovic Courtès, 2016/09/11
- [PATCH 14/17] gnu: linux-libre: Use kmod., David Craven, 2016/09/09
- Re: [PATCH 14/17] gnu: linux-libre: Use kmod., Ludovic Courtès, 2016/09/11
Re: Linux kernel, Ludovic Courtès, 2016/09/09
- Re: Linux kernel,
David Craven <=