guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] gnu: encfs: Update to 1.9.


From: Tobias Geerinckx-Rice
Subject: Re: [PATCH 2/2] gnu: encfs: Update to 1.9.
Date: Mon, 12 Sep 2016 15:54:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

Ludo',

On 12/09/16 15:42, Ludovic Courtès wrote:
>> +       (snippet '(for-each delete-file-recursively
>> +                           (find-files "internal" "tinyxml2")))))
> 
> Note that the 2nd argument to ‘find-files’ is a regexp.  Is this really
> intended?

It is. The directory to be deleted is actually named "tinyxml2-3.0.0"
(or so), with future version bumps too easy to miss.

This seemed like the clea{n,r}est syntax, but then I'm already familiar
with find-files. I could change it to "^tinyxml2" for no other reason
than to scream ‘I'm a regex’ if you think that's needed.

> Otherwise LGTM, thanks!

Thank you!

Kind regards,

T G-R

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]