Re: [PATCH 4/7] gnu: Add llvm-for-extempore.

[Thompson, David]

On Wed, Sep 14, 2016 at 5:38 AM, Ricardo Wurmus <address@hidden> wrote:
> * gnu/packages/llvm.scm (llvm-for-extempore): New variable.
> ---
>  gnu/packages/llvm.scm | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index a9eba79..b55a200 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright © 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright © 2015 Ludovic Courtès <address@hidden>
>  ;;; Copyright © 2016 Dennis Mungai <address@hidden>
> +;;; Copyright © 2016 Ricardo Wurmus <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -267,3 +268,10 @@ code analysis tools.")
>  (define-public clang-3.5
>    (clang-from-llvm llvm-3.5 clang-runtime-3.5
>                     "0846h8vn3zlc00jkmvrmy88gc6ql6014c02l4jv78fpvfigmgssg"))
> +
> +(define-public llvm-for-extempore
> +  (package (inherit llvm-3.7)
> +    (source
> +     (origin
> +       (inherit (package-source llvm-3.7))
> +       (patches (list (search-patch "llvm-for-extempore.patch")))))))

This could use a comment explaining the rationale.  Also, you forgot
to include the patch file in this commit.

- Dave