[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel varian
From: |
Vincent Legoll |
Subject: |
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant. |
Date: |
Mon, 26 Sep 2016 18:57:45 +0200 |
> I entirely agree.
I'm not alone :-)
> Our current convention for commit messages is aesthetically pleasing,
> but useless. It is redundant to put in the message WHAT has changed.
> That can be easily determined by running "git show". What is much
> more usefull is the reason WHY we changed it.
+1
> Recently, on another project, I came across a line of code which I
> was pretty sure was pointless. I was about to delete it - but I
> decided to check first. So I ran "git blame" to find out which
> commit had added it. Then I ran git show to get the full details
> of that commit. Fortunately, the person who had committed it 5 years
> ago had mentioned exactly why it was needed. - and it was there
> for a very valid reason too. Had we been using the Guix convention,
> this would probably have been deleted and consequences would have
> followed.
Been there, done that...
> I vote that we make the reason for a commit to be compulsory. All
> other details optional.
+1, more details is better than less, LKML-style...
--
Vincent Legoll
- Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install argument., (continued)
[PATCH 2/6] gnu: %default-extra-linux-options: Remove redundant options., David Craven, 2016/09/26
[PATCH 6/6] gnu: make-u-boot-package: Don't cross compile on arm., David Craven, 2016/09/26
[PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., David Craven, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., David Craven, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Vincent Legoll, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ricardo Wurmus, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant.,
Vincent Legoll <=
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Leo Famulari, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., David Craven, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Vincent Legoll, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., David Craven, 2016/09/26
- Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Leo Famulari, 2016/09/26
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Ludovic Courtès, 2016/09/28
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Tobias Geerinckx-Rice, 2016/09/27
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., Mark H Weaver, 2016/09/27
Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant., John Darrington, 2016/09/28