Re: [PATCH v2] gnu: Add sunxi-tools.

[Ludovic Courtès]

Danny Milosavljevic <address@hidden> skribis:

> * gnu/packages/admin.scm (sunxi-tools): New variable.
> ---
>  gnu/packages/admin.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 6981242..06c552f 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1846,3 +1846,35 @@ Kerberos and Heimdal and FAST is supported with recent 
> MIT Kerberos.")
>      (license license:gpl1+)))
>  
>  ;;http://archives.eyrie.org/software/kerberos/pam-krb5-4.7.tar.xz
> +
> +(define-public sunxi-tools
> +  (package
> +    (name "sunxi-tools")
> +    (version "1.3")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/linux-sunxi/";
> +                           "sunxi-tools/archive/v" version ".tar.gz"))
> +       (sha256
> +        (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        ;; Source is included anyway.
> +        '(delete-file-recursively "bin"))))

The comment should rather be “Remove binaries contained in the tarball.”

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("libusb" ,libusb)))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; no tests exist
> +       #:make-flags (list (string-append "PREFIX="
> +                                         (assoc-ref %outputs "out")))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure))))
> +    (home-page "https://github.com/linux-sunxi/sunxi-tools";)
> +    (synopsis "Tools to help manage Allwinner A10 devices")
> +    (description "This package contains tools for Allwinner A10 devices (for 
> FEX, FEL USB, PIO, NAND, JTAG, RAM)")

I don’t understand this description.  Since “Tools”, “manage”, and
“devices” could mean anything, could you add qualifiers to give more
context, like:

  “Frobbing tools for Allwinner A10 foobar devices”

and similarly expound the description (with a period at the end of the
sentence)?

Based on that, we might device that admin.scm is not the best fit for
this package.  Maybe flashing-tools.scm?

Could you send an updated patch?

Thanks in advance!

Ludo’.