guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: %static-inputs: Use bash from PATH in bootstrap tar.


From: Ludovic Courtès
Subject: Re: [PATCH] gnu: %static-inputs: Use bash from PATH in bootstrap tar.
Date: Wed, 19 Oct 2016 21:48:11 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Efraim Flashner <address@hidden> skribis:

> On Wed, Oct 19, 2016 at 05:34:17PM +0200, Ludovic Courtès wrote:
>> address@hidden (Carlos Sánchez de La Lama) skribis:
>> 
>> > See
>> > <http://lists.gnu.org/archive/html/guix-devel/2016-09/msg02272.html>.
>> 
>> Could you put this URL next to the “Do not use /bin/sh” comment?
>> 
>> > gnu/packages/make-bootstrap.scm (%static-inputs): Use bash from PATH.
>> 
>> Otherwise LGTM, thanks!
>> 
>> Ludo’.
>> 
>
> Was this tested with the other bootstrap binaries?

It changes execv("/bin/sh", …) to execvp("sh", …) so it looks right.

> I'm still having trouble with the aarch64 ones, didn't check if/how it
> affected the ones that are already in Guix (which I assume would be
> not at all)

What kind of problems?  After this patch?

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]