Re: [PATCH] gnu: link-grammar: New module.

[Leo Famulari]

On Sun, Oct 23, 2016 at 04:54:17PM +0200, Amirouche Boubekki wrote:
> From 391889d22f102368cc44d6a0a928fccd20810269 Mon Sep 17 00:00:00 2001
> From: Amirouche <address@hidden>
> Date: Sun, 23 Oct 2016 16:46:12 +0200
> Subject: [PATCH] gnu: link-grammar: New module
> 
> * gnu/packages/link-grammar.scm: New module.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add new file.

Thanks! This should go in (gnu packages language). I would have moved it
there myself if not for a different problem...

> +    (inputs `(("sqlite" ,sqlite)
> +              ("zlib" ,zlib)))

The built output of the package does not refer to sqlite or zlib:

$ guix gc --references $(./pre-inst-env guix build link-grammar)
/gnu/store/7njyh7586r6kk2lfbz2wg52n3la89zda-link-grammar-5.3.11
/gnu/store/9nifwk709wajpyfwa0jzaa3p6mf10vxs-gcc-4.9.3-lib
/gnu/store/m9vxvhdj691bq1f85lpflvnhcvrdilih-glibc-2.23

This means that when the user eventually collects garbage with `guix
gc`, the sqlite and zlib libraries that link-grammar uses may be
deleted, breaking link-grammar.

If sqlite and zlib are only used when building, but not when running
link-grammar, then they should be native-inputs.

Otherwise, we will need to figure out how to make link-grammar retain
references to these libraries.