guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] gnu: Add hidapi.


From: Theodoros Foradis
Subject: Re: [PATCH 2/3] gnu: Add hidapi.
Date: Wed, 26 Oct 2016 21:29:03 +0300
User-agent: mu4e 0.9.17; emacs 25.1.1

David Craven writes:

> I don't think we need this:
>
> (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +                    (lambda _
> +                      (system* "./bootstrap")
> +                      #t)))))
>
>> +    (native-inputs `(("autoconf" ,autoconf)
>> +                     ("libtool" ,libtool)
>> +                     ("automake" ,automake)
>> +                     ("pkg-config" ,pkg-config)))
>

There is no configure script in the release tarball, so I think we
either need this or:
(lambda _
  (system* "autoreconf" "-vfi")
  #t)

Can't build without neither.
> Is license is gpl3+
>
> +    (license license:gpl3)))
>
LICENSE.txt says:
HIDAPI can be used under one of three licenses.
1. The GNU General Public License, version 3.0, in LICENSE-gpl3.txt

What am I missing?
> Input list indentation.

Thanks for letting me know.
-- 
Theodoros Foradis



reply via email to

[Prev in Thread] Current Thread [Next in Thread]