[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] improve nginx-service
From: |
Julien Lepiller |
Subject: |
Re: [PATCH] improve nginx-service |
Date: |
Fri, 4 Nov 2016 19:01:29 +0100 |
On Fri, 04 Nov 2016 14:21:43 +0100
address@hidden (Ludovic Courtès) wrote:
> Hartmut Goebel <address@hidden> skribis:
>
> > Am 03.11.2016 um 15:54 schrieb Ludovic Courtès:
> >> Assuming ‘demo-website’ is bound to a package object, you should
> >> be able to do:
> >>
> >> (root (file-append demo-website "/"))
> >>
> >> or simply:
> >>
> >> (root demo-website)
> >
> > Hmm, this does not work for me:
> >
> >
> > ice-9/boot-9.scm:702:27: In procedure map:
> > ice-9/boot-9.scm:702:27: In procedure string-append: Wrong type
> > (expecting string): #<package
> > address@hidden ./taler/packages/demo.scm:100
> > 3e2a600>
> >
> >
> > I tried with current master branch.
>
> Doh! Indeed, ‘default-nginx-vhost-config’ must be rewritten to do
> something like:
>
> #~(string-append #$foo #$bar …)
>
> instead of:
>
> (string-append foo bar …)
>
> More precisely, it could ‘string-append’ all the string literals yet
> use a #~(string-append …) gexp for ‘root’.
>
> Julien? :-)
I think it's good now. There are three patches:
1. making the service extensible (mostly what you wrote last time)
I used an empty list as the default list of vhosts.
2. a patch to fix an issue when multiple index files and server name
were specified (there were no space in between)
3. a patch to allow any configuration option to come from the store (I
couldn't write something specific to the root option, but I think
it's fine this way). I tested with the example I added in the
documentation, and it works fine.
I hope I did it right :)
>
> Ludo’.
0001-Make-nginx-service-extensible.patch
Description: Text Data
0002-service-Fix-multiple-index-and-server-name.patch
Description: Text Data
0003-services-Accept-gexps-as-nginx-configuration-value.patch
Description: Text Data
- Re: [PATCH] improve nginx-service, Hartmut Goebel, 2016/11/02
- Re: [PATCH] improve nginx-service, Ludovic Courtès, 2016/11/03
- Re: [PATCH] improve nginx-service, Hartmut Goebel, 2016/11/03
- Re: [PATCH] improve nginx-service, Ludovic Courtès, 2016/11/04
- Re: [PATCH] improve nginx-service,
Julien Lepiller <=
- Re: [PATCH] improve nginx-service, Hartmut Goebel, 2016/11/04
- Re: [PATCH] improve nginx-service, Julien Lepiller, 2016/11/04
- Re: [PATCH] improve nginx-service, Hartmut Goebel, 2016/11/04
- Re: [PATCH] improve nginx-service, Julien Lepiller, 2016/11/06
- Re: [PATCH] improve nginx-service, Hartmut Goebel, 2016/11/04
- Re: [PATCH] improve nginx-service, Tobias Geerinckx-Rice, 2016/11/06
- Re: [PATCH] improve nginx-service, Ludovic Courtès, 2016/11/06
- Re: [PATCH] improve nginx-service, Julien Lepiller, 2016/11/20
- Re: [PATCH] improve nginx-service, Hartmut Goebel, 2016/11/22
- Re: [PATCH] improve nginx-service, julien lepiller, 2016/11/23