[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mps-youtube, revision 3
From: |
ng0 |
Subject: |
Re: [PATCH] mps-youtube, revision 3 |
Date: |
Sat, 05 Nov 2016 12:49:50 +0000 |
Marius Bakke <address@hidden> writes:
> Hartmut Goebel <address@hidden> writes:
>
>> Am 04.11.2016 um 20:23 schrieb ng0:
>>> [PATCH 1/2] gnu: Add python-pafy.
>>>
>>> - made youtube-dl propagated-input as suggested by harmut
>>>
>>> [PATCH 2/2] gnu: Add mps-youtube.
>>>
>>> - no changes
>>>
>>
>> Both LGTM.
>>
>> Adding the comment about youtube_dl was a good idea :-)
>
> Both of these packages have 'or later' in the source license header.
> Also mps-youtube does not need mpv or ffmpeg in inputs, since they are
> optional runtime dependencies.
Oh... I had forgotten about these two changes I wanted to
make. Thanks for fixing it!
> Additionally home-page should be https.
>
> Other than that this works great, neat program!
>
> I pushed the patches with these changes, and a minor edit to the
> mps-youtube description to make it clear that mplayer or mpv is
> required.
>
- [PATCH 1/2] gnu: Add python-pafy., (continued)
- [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/02
- Re: [PATCH 1/2] gnu: Add python-pafy., Hartmut Goebel, 2016/11/02
- Re: [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/04
- Re: [PATCH 1/2] gnu: Add python-pafy., Hartmut Goebel, 2016/11/04
- Re: [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/04
- [PATCH] mps-youtube, revision 3, ng0, 2016/11/04
- [PATCH 1/2] gnu: Add python-pafy., ng0, 2016/11/04
- [PATCH 2/2] gnu: Add mps-youtube., ng0, 2016/11/04
- Re: [PATCH] mps-youtube, revision 3, Hartmut Goebel, 2016/11/04
- Re: [PATCH] mps-youtube, revision 3, Marius Bakke, 2016/11/05
- Re: [PATCH] mps-youtube, revision 3,
ng0 <=
Re: [PATCH] mps-youtube, Marius Bakke, 2016/11/02