guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/5] install: Extract procedure: install-grub-config.


From: Chris Marusich
Subject: Re: [PATCH 4/5] install: Extract procedure: install-grub-config.
Date: Sun, 06 Nov 2016 17:25:51 -0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Danny Milosavljevic <address@hidden> writes:

> Thanks for this!
>
>> -(define* (install-grub grub.cfg device mount-point)
>> +(define (install-grub grub.cfg device mount-point)
>>    "Install GRUB with GRUB.CFG on DEVICE, which is assumed to be mounted on
>>  MOUNT-POINT.
>>  
>>  Note that the caller must make sure that GRUB.CFG is registered as a GC root
>>  so that the fonts, background images, etc. referred to by GRUB.CFG are not
>>  GC'd."
>> +  (install-grub-config grub.cfg mount-point)
>> +  (unless (zero? (system* "grub-install" "--no-floppy"
>
> ^^^ since you have touched it, maybe you know: How does it know which 
> package's (which directory's) grub-install to invoke here?

There is logic in the perform-action procedure in (guix scripts system)
which adds GRUB to the PATH environment variable.  That's where the
determination occurs.  So, currently, it looks like the 'grub-install'
command comes from whatever version of grub happens to be defined in
(gnu packages grub) at the time perform-action gets called.  In
practice, I believe this means that whatever grub version is currently
available in guix (e.g., as seen via 'guix package --show=grub') will be
used.

Hope that helps!

-- 
Chris

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]